Flexbox, html, css, google fonts

Community feedback

• 

  P

  Liam•360

  @asmthliPosted about 1 month ago

  Hey David,

  Good job. Don't stress about not understanding everything to begin with - just take everything you learn as a small win.

  In regards to the trouble you're having with setting the size for elements, I'd suggest only setting a width for the image. By default, if you set a width, it should retain the same aspect ratio and so the height should be adjusted automatically so it remains a square. That would fix the main difference I noticed between your implementation and the design - the image is stretched currently.

  The way you've centred the div is spot on I'd say. The standard way to do such a thing these days is to give the parent container a display of 'flex' and then use 'align item: center' and 'justify-content: center'. This will centre it to the parent container. If you want it centred in the middle of the screen, you need to be sure that the parent container is the size of the screen then. The parent container of the div is the body element and so you need to make this the size of the screen. By default I believe the body is always 100% width. The height is slightly trickier though because by default it will have a height large enough only to contain its child elements. A way to make it the full screen height (but also allow it to grow larger if needs be) is to set (min-height: 100vh). The vh unit stands for 'view height' and will always be equal to 1% of the screen height.

  Hope that helped somewhat and wasn't overwhelming :)

  Marked as helpful

  0

  ---

  

  geomydas•1,400

  @geomydasPosted about 1 month ago

  @thanderwism the body seems to be width: 100% since it is a block element, technically its width: auto

  1
• 

  Jala30•20

  @Jala30Posted about 1 month ago

  Hi,

  Just suggesting some improvements - In the desgin, the image seems equal in height and width, while in your preview the height seems greater than width. Also the left the right padding for the image can be a little bit greater. Due to this lack of padding - your preview looks a little congested.

  Also to your question, the method you used to center is a pretty standard ways. Using classnames for the elements would make it a bit more optimized.

  0