Design comparison
Solution retrospective
1.I will not face any difficulties in this project 2.before 200px
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @ubaidrashid!
Your solution looks great!
I have a couple of suggestions (about semantic HTML) for improvement:
š First: Use
<main>
to wrap the main content instead of<div>
.Think of
<div>
and<span>
in HTML like plain boxes or placeholders. They're handy for holding content, but they don't tell us anything about what's inside or what it's meant for on the webpage.š Second: Wrap the main title with
<h1>
in addition to the<a>
tag. That text is a link to an external page, but it's also the main title of the screen.Unlike what most people think, it's not just about the size and weight of the text.
- The
<h1>
to<h6>
tags are used to define HTML headings. <h1>
defines the most important heading.<h6>
defines the least important heading.- Only use one
<h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>
, then use<h2>
, and so on.
All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
0@ubaidrashidPosted 8 months ago@danielmrz-dev Thank you for your understanding. š You're a great teacher, and I'll make sure to correct all these mistakes in the future. š
0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord