Skip to content
Submitted 3 months ago

Flexbox for QR Code Responsive Design

Adrian Albino•100
@adrianalbino
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Øystein Håberg•10,390
    @Islandstone89Posted 3 months ago

    HTML:

    • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Change .container into a <main>.

    • All images must have alt text. The alt text should be written naturally, without using - between the words. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

    • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

    CSS:

    • It is best practice to write CSS in a separate file, often called style.css. Create one in the same folder as the index.html, and link to it in the <head>: <link rel="stylesheet" href="style.css">.

    • Including a CSS Reset at the top is good practice.

    • I like to add 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

    • On the body, change height to min-height - this way, the content will not get cut off if it grows beneath the viewport.

    • I would move the properties, except height, from .container to body. Delete the .container selector, as it doesn't need any styles.

    • Remove all widths and heights in px.

    • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

    • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

    • letter-spacing must also never be in px. You can use em, where 1em equals the element's font size.

    • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

    • Likewise, font-family should be set on the body, and removed elsewhere.

    • Remove font-family: 400, as that is an invalid value for that property.

    • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container.

    • The card should have padding on all sides, not just the top. Replace padding-top with padding: 16px;. When you write only one value, this is a shorthand for setting padding-top, padding-right, padding-bottom and padding-left.

    Marked as helpful
    1
  • NaoMauss•30
    @NaoMaussPosted 3 months ago

    Not much to say here, you completed almost perfectly this challenge ! There seem to be just a little issue with the height of the div but you're probably already aware of that. Otherwise i don't have any advice to give you for the code, maybe it would be better to put it in a separate css files but i guess that depends of your tastes

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord