Manuel Matus• 70
@ManudeQuevedo
Posted
Congrats! It works fine!
This is my feedback for you, hope it helps:
- To make it easier on responsiveness, I suggest you follow the mobile-first approach, you start developing for smaller screen resolutions and then with the @media or CSS Grid, you can change the look and feel of the elements.
- In your JavaScript, I strongly recommend you give your variable more meaningful names, this will allow you and other devs to understand your code. As developers, we tend to forget that other dev might read our code and take the time to declare well-named variables will save you and others a lot of time.
- Also in your JS, try to follow the camelCase way of declaring a variable, I see you did it with the validRegex but not with the emailid. This is all about being consistent with the code you write.
Marked as helpful
1