flexbox, centerlizing, max-width,positioning,vars,media.

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted over 2 years ago

  @emadbakry is a best practice, note that the h1 is the most important and the h6 the less important, using this headings you show what information is more important and create and hierarchy. To make it bold just use font-weight: bold. Feel free to ask me anything 👍

  0

  ---

  

  Emad•270

  @emadbakryPosted over 2 years ago

  @correlucas thank you BIG much.

  1
• 

  Lucas 👾•104,340

  @correlucasPosted over 2 years ago

  Hello again Emad, congratulations for your solution!

  I've some tips for your to improve you solution :

  I saw that you've used a div to wrap both desktop and mobile images, there's a better way to do it, you cana also manage the product image inserting the tag <picture> to wrap both desktop and mobile images together in the same tag, and render each image depending of the device (phone / computer) by the settings for the width you'll insert in the html If you're not familiar with the picture tag you can look at the documentation to see how to set it: https://www.w3schools.com/tags/tag_picture.asp

  About the headings I saw youve used a h6, in this case is better you use the headings increasing just one level, example h1, h2, h3... Without jump the sequence.

  Hope it helps, happy coding!

  0

  ---

  

  Emad•270

  @emadbakryPosted over 2 years ago

  @correlucas thanks again for the feedback but does (using h2 and then h6) has an impact on SEO ? the reason i used h6 is to make it less bold, i didnt know which one is better for SEO.

  1