Submitted almost 3 years ago

Flexbox, BEM Naming Convention

Ayaat•460

@Yazeed-git

Preview site View code

This is a solution for...NFT preview card component

HTML
CSS

1newbie

Design comparison

SolutionDesign

Solution retrospective

Any feedback on this project is welcome

Community feedback

PhoenixDev22•16,950
@PhoenixDev22Posted almost 3 years ago
Greetings, I think you did a great job in styling your solution and overall your solution looks good.

To get rid of the accessibility issues shown in your Report, I would suggest to:

Wrap everything in your body in <main> ... OR use semantic tags ... OR give role="" to the direct children of your <body> ... Click here to read more

Have at least one <h1> in your code. Click here to read more

Also, For the mobile , <span class="avatar-name">Jules Wyvren</span> wraps in 375px width.

hope this feedback helps. Happy coding
Marked as helpful
0
Ayaat•460
@Yazeed-gitPosted almost 3 years ago
@PhoenixDev22 Thanks for the feedback, I'll look into resolving the issues
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord