QR code component - Flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  COMPONENT MEASUREMENTS 📐:

  • Use min-height: 100vh for .container instead of height: 900px. Setting the height: 900px may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 900px then the .container will have 900px height no matter what. Even if the content spans more than 900px of viewport.

  ---

  • But if we set min-height: 100vh then the .container will start at 100vh, if the content pushes the .container beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Elouka972•80

  @Elouka972Posted over 1 year ago

  @0xAbdulKhalid Thank you so much for your help !

  0
• 

  Josh•1,110

  @josh76543210Posted over 1 year ago

  Hello @Elouka972,

  Great job on your solution. Looks good!

  One thing that I think would make your page even better is to remove height: 900px; on the container and replace it with min-height: 100vh;. The min-height will help center the card and the removal of the fixed height will make the page more responsive and prevent large empty spaces from appearing above and below the card on smaller screens.

  Keep up the good work and happy coding!

  Marked as helpful

  0

  ---

  

  Elouka972•80

  @Elouka972Posted over 1 year ago

  @josh76543210 Thank you :)

  0