Flexbox and very small amount of Java and Grid

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 3 years ago

  • look into responsive images techniques mainly picture element or srcset, those are considered part of responsive web design. The method you used below works but is not part of responsive web design - it is considered among other things expensive and uses a lot of bandwidth as all images have to be downloaded.

  <div class="nav-wrapper">
   <img class="mobile-hero-images" src="images/mobile/image-header.jpg" alt="">
   <img class="desktop-hero-images" src="images/desktop/image-header.jpg"  alt="">
    </div>
  

  ***** &&&&&&&&&&&&&&&&&& ***

  <img class="hamburger" src="images/icon-hamburger.svg" alt="">
  <img class="cross hide" src="images/icon-close.svg" alt="">
  this should have been  interactive elements -  button
  

  • semantic matters , use elements that are meant for the task.

  Marked as helpful

  1

  ---

  

  Igor•45

  @IgorVanVuurenPosted about 3 years ago

  @ChamuMutezva Tnx man appreciate the feedback, will definitely look into it :)

  0