Skip to content
Submitted about 4 years ago

Flexbox and GSAP

Mohamed NDOYE•70
@mohamed-ndoye811
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Article preview component
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hii, I hope this solution is the closest possible to the original challenge. I would lik to have maybe feedback on the organization of my html and scss (mostly on the class names because it seems kinda complicated to me..). Thanks in advance!

Community feedback

  • Dawid•440
    @dwddgszPosted about 4 years ago

    Hello. You used a lot of underscores. It makes your code hard to read. For example: instead of 'article-wrapper-text' you could use just "article-text" and instead of 'article-wrapper-footer' you could use 'footer' and then 'footer-avatar', 'footer-username'. Read some more about BEM, maybe you will find it useful. Hope I could help.

    1
    Mohamed NDOYE•70
    @mohamed-ndoye811Posted about 4 years ago

    @dwddgsz Hello. Okay yeah you're right that sounds way more clear to read. I'll do it and edit my code. Thanks for your feedback!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord