@kassahunAmdie
Posted
hi @matt2282, good job in completing the challenge and you did good. The way you structured your code is easy to follow along. For the question you asked, "Is my code deviating from any best practices?", I noticed two major things you may want to consider.
- Try not to use "h1" more than once on your webpage.
- It is best practice to put your CSS in its own file. (Forget this one. I realized you have mentioned about it)
One last thing, as far as the solution is concerned is, you missed the hover state as outlined in the design file. May be you were like me, so excited you forgot about it. But all in all very good job. Keep working on it.