Frontend Mentor | Flexbox coding challenge solution

Solution retrospective

What are you most proud of, and what would you do differently next time?

I feel that my interface is quite complete and similar to the Figma design.

What challenges did you encounter, and how did you overcome them?

At first, I had some difficulty reviewing old CSS knowledge, but it didn’t take too long for me to overcome it.

What specific areas of your project would you like help with?

I look forward to receiving feedback, evaluations, and suggestions on what I need to improve.

Community feedback

@Zxjklp

Posted 5 days ago

Semantic HTML

Strengths: The code uses some semantic HTML elements like <head>, <body>, and <div>.
Improvements: Consider using more semantic elements such as <main> and <footer> to improve the structure and accessibility of the document. For example, the container div could be a <main> element.

Accessibility

Strengths: The use of alt attribute for the image is good for accessibility.
Improvements:
- The text inside the alt attribute must say where it leads.
- Ensure that the text inside the div elements is accessible by using appropriate heading tags like <h1>, <h2>, etc., instead of <div>.
- The attribution section could be wrapped in a <footer> element to better indicate its purpose.

Layout and Responsiveness

Strengths: The use of Flexbox for layout is a good choice for creating a responsive design.
Improvements:
- The width and height properties set in pixels could be converted to relative units like percentages or rem to make the layout more responsive.

Code Structure, Readability, and Reusability

Strengths: The code is relatively well-structured and uses classes to apply styles.
Improvements:
Avoid inline styles within the style tag in the HTML. Instead, move the styles to an external CSS file for better maintainability.
- Use lowercase for HTML tags and attributes to maintain consistency and readability (e.g., div instead of Div).

Design Consistency

Strengths: The design seems to follow the challenge requirements.
Improvements:
- Ensure that the design matches the provided design specifications in terms of spacing, font-family, and color.

Marked as helpful

MikDra1• 6,090

@MikDra1

Posted 5 days ago

I encourage you to use this technique to make the card responsive with ease:

.card {
width: 90%;
max-width: 37.5rem;
}

On the smaller screens card will be 90% of the parent (here body), but as soon as the card will be 37.5rem (600px) it will lock with this size.

Also to put the card in the center I advise you to use this code snippet:

.container {
display: grid;
place-items: center;
}

Hope you found this comment helpful 💗💗💗

Good job and keep going 😁😊😉

Marked as helpful

@Davzp1980

Posted 5 days ago

Включает решение семантический HTML Улучшений не требуется Макет хорошо выглядит на разных размерах экрана

Flexbox