flexbox

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Riddhidipta, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the card for improve the Accessibility
  • img element must have an alt attribute, it's very important!
  • if you write the width attribute in the img tag you don't have to specify the px size, just the number
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • the <br> is for break the text not to divide elements
  • use h1 and not div for the title of card
  • use semantic html like button for the payment button
  • add a little transition on the element with hover effect
  • instead of using px try to use relative units of measurement -> read here
  • for add the top image in the background just put more specific background properties to the body:

  background: url("../img/pattern-background-desktop.svg") no-repeat top center;
  background-size: contain;
  background-color: #e0e8ff;
  

  Overall you did well 😉

  Hope this help and happy coding!

  Marked as helpful

  0

  ---

  

  Riddhidipta Pal•110

  @CodingLife1024Posted over 2 years ago

  @denielden Thank you for your feedback. Could you suggest some good free resources for learning javascript? Thanking you Riddhidipta

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  @CoderBoi1024 You are welcome! Sure, follow the links:

  • javascript.com
  • codecademy
  • freecodecamp

  Marked as helpful

  0

  

  Riddhidipta Pal•110

  @CodingLife1024Posted over 2 years ago

  @denielden Thanks a ton !!!

  1