Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

flexbox

John 210

@gt78x

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback on improving is appreciated.

Community feedback

Travolgi 🍕 31,420

@denielden

Posted

Hello John, You have done a good work! 😁

Some little tips to improve your code:

  • you can use article tag instead of a simple div to the container card for improve the Accessibility
  • use img element instead of a styled div for the qr image
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div without scope
  • use min-height: 100vh to section tag instead of height, otherwise the content is cut off when the browser height is less than the content

Keep learning how to code with your amazing solutions to challenges.

Hope this help 😉 and Happy coding!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord