Minimalist Perfume Card Using Flexbox
Design comparison
Solution retrospective
Any Feedback Is Greatly Appreciated!
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Gabriel Ferreira, Congratulations on completing this challenge!
Your solution its almost done and I’ve some tips to help you to improve it:
Add the website favicon inserting the svg image inside the
<head>
.<link rel="icon" type="image/x-icon" href="./images/favicon-32x32.png">
I saw that for some properties you’ve used
rem
and for otherspx
. In this case, it is better to use only one kind of unit to have a better organization for your code.relative units
asrem
orem
have a better fit if you want your site more accessible between different screen sizes and devices.REM
andEM
does not just apply to font size, but to all sizes as well.👨💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1
✌️ I hope this helps you and happy coding!
Marked as helpful1 - @mhz-777Posted about 2 years ago
Looks good!
If I had to suggest anything for the sake of nit-picking it would be to add some margin and smaller mobile devices like the iPhone SE and the Samsung S10 for example.
Otherwise looks really nice good work :))
0@WillamiFerreiraPosted about 2 years ago@mhz-777 thanks for the feedback .😊 I'll take care about this on the next work.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord