Design comparison
Solution retrospective
Please share you feedback. The most challenging for me in this challenge was how to do image overlay.
Community feedback
- @macdeeshPosted over 2 years ago
Hello @Fsanea, First, you need to change the HTML in this. Think about when you use the Web. What do you expect when you see a hover effect? You know something is clickable, right? That means it's an interactive element. Every place you see a hover style, you need to include an interactive element, like an anchor tag or button. That is essential to fix.
I would recommend using pseudo-element like :: after or ::before to put the SVG icons, rather than adding extra in the HTML. But that's not essential. That way, you can remove the decorative elements from the HTML structure. Additionally, you should have no text in spans alone. Always use meaningful elements, like paragraphs, headings, lists etc. Finally, I would recommend using <div> instead of <section>. The section element represents a generic section of a document or application, it is a thematic grouping of content. The theme of each section should be identified, typically by including a heading (h1-h6 element) as a child of the section element.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord