Flexbox

Community feedback

• 

  P

  Marcus•160

  @marcus-hillPosted about 2 months ago

  Hi James,

  The design looks good and I think you have done well with that. However, the obvious issue is the positioning of the card which is not currently in the middle of the screen. Setting a min-height on the body element should solve this problem I believe.

  Hope that helps!

  Marked as helpful

  1

  ---

  

  James Morrissey Jr•50

  @JammiMPosted about 2 months ago

  @marcus-hill That's great advice thanks !

  0
• 

  AntoineMu•30

  @AntoineMuPosted about 2 months ago

  Hi James,

  I really like how close you got to the suggested design, as well as your use of the @media query. I see you used flexbox on the body element to center your component horizontally. You can use align-items: center; on the body to center your element vertically. If you do this, you don't need to set a top margin on your qr-code-component. Also, if you set the you are going to use your font for every element, you can set it for the body element and all other elements will inherit the font. By doing this you don't have to set the font-family for every element.

  Marked as helpful

  1

  ---

  

  James Morrissey Jr•50

  @JammiMPosted about 2 months ago

  @AntoineMu Thanks that's smart, I didn't think of that approach, I greatly appreciate the time that you took for your review!

  1