flexbox

Community feedback

• 

  paulDev•500

  @dev-paulLPosted 3 days ago

  hi, quick 5min review, i probably missed things.

  • put your page content in <main>
  • h1? this would not be a page title on a real website, h2 would make more sense.
  • fix typos (you can copy paste the text from the given index.html)
  • say where the code leads to in the alt (qr code to front end mentor website)
  • don't give your container a fixed width, i would use max-width in rem
  • don't use pixels for font, use 'rem' or 'em' so it respects browser font-size preferences
  • i get a 404 on your gh repo

  happy coding :)

  Marked as helpful

  1

  ---

  

  shaikh zayed•60

  @undersigned-devPosted 3 days ago

  @dev-paulL did as you asked thanks for the review :)

  0
• 

  Dylan Heslop•1,570

  @dylan-dot-cPosted 3 days ago

  Well done! It seems that your repository might be private so I can't really inspect your code right now, so make it public then I can check.

  Also there is a border radius you don't have so you can add that. But well done from what I can see

  0