Design comparison
Solution retrospective
Please tell me the mistakes and defects of my work. Thank you.
Community feedback
- @HassiaiPosted over 1 year ago
Replace <div class="continer"> with the main tag and <p class="top-part"> with <h1> to fix the accessibility issue. click here for more on web-accessibility and semantic html
Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.
To center .continer on the page using flexbox, replace the height in the body with min-height: 100vh.
For a responsive content , give .continer a width of 80vw or a max-width of 1440px and a width of 80%.
For the color of the image add a background-color of soft violet, background-blend-mode: multiply and opacity:0.8 to the img.
.img{ background-image: url(); background-size: cover; background-color: hsl() background-blend-mode: multiply; opacity: 0.8; }
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord