Skip to content
Submitted about 2 years ago

Flex-box

Flaviu Dragomir•150
@FlaviuD94
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Account deleted

    Hello @FlaviuD94,

    Welcome to Frontend Mentor community!

    Your solution looks awesome and I suggest you add one landmark to your page:

    I hope this helps and good luck

    Marked as helpful
    2
  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hi , congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

    • Replace the <h2> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
    • Reduce your code by removing unnecessary elements. The HTML structure is working but you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.
    <body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    1
  • Flaviu Dragomir•150
    @FlaviuD94Posted about 2 years ago

    Hello,

    Thank you for your warm welcoming! I have applied all your suggestions and I much appriciated your feedback. Also I modified h1 font-size to better match with the exemple provided in the challange and I change a bit the padding and the border-radius for a better match.

    Wish you all the best!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord