Flexbox and BEM

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 3 years ago

  👋Hi Hernan!

  I recommend to not use another image to respect the designer 😉.

  Also, about your branching, I think the git branch should be used for things, like updating, refactoring, fixing bug, etc. It's not going to be your main branch. I recommend to use master or main branch as your main branch.

  More feedback:

  • For the comments, I recommend to use English so that most people can understand what are you going to explain.
  • I recommend to wrap all your page content, except the attribution with main tag. It's important that every page content live inside the landmark.
  • For the attribution. I recommend to swap the div with footer tag.
  • Heading tag order is important. You need to use h1, h2, h3 and so in a chronological order.
  • I recommend for the Order Summary words to use h1.
  • For Annual Plan, I recommend to use strong tag instead of heading tag. Heading tag is commonly used for titling a section.
  • In this challenge, all the images are decorative only, meaning that if the image doesn't exist, the user still can understand what's going on in this page. So, for the decorative images, you should leave the alt="" empty and add aria-hidden="true" or role="presentation" to make sure all screen readers will ignore those images.
  • Try to make it looks as similar as the design.
  • Use rem or sometimes em. Using px will prevent the user from scaling the size of your page.
  • You need to use the font-family to make it work. Only importing the font family doesn't change the font family.

  That's it! Hopefully this is helpful!

  Marked as helpful

  2

  ---

  

  Hernan Alex Choque Condori•235

  @HernanAlex61ChoqueCondori8Posted about 3 years ago

  @vanzasetia Hi 👋, Thanks for the recommendations helped me a lot (• ◡ •) /

  0