Design comparison
SolutionDesign
Solution retrospective
I had a lot of problems on this one: -On the smartphone in landscape mode, the navbar doesn't display. -I also had other problems with queries, which I think I may have solved. If a mentor comes by, please take a look at my work. Thanks for your time.
Community feedback
- @ApplePieGiraffePosted over 2 years ago
Hi, seruaJ! 👋
Nice effort on this challenge! 👏
A couple of things I'd like to suggest are,
- Turning the navigation links in the header of the page into actual links by using link tags (instead of button tags) for those elements.
- Avoiding setting specific heights for things like containers and sections in your page. It's often better to simply allow the height of elements to be determined by their content (which is their default behavior) because then they will be just as high as they need to in order to accommodate what's inside them. You can always use margin or padding to add extra space around or inside those elements if desired. 😉
- Turning the social media icons in the footer page into links as well by wrapping them in link tags.
- Adding
object-fit: coverto the images in this challenge so that they do not appear to be squeezed or stretched when their aspect ratio or dimensions change.
Hope you find this helpful. 😊
Keep coding (and happy coding, too)! 😁
Marked as helpful1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord