Design comparison
Community feedback
- @DylandeBruijnPosted 5 months ago
@Iridelis40
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve ✍️
-
Add a bit of padding to your body element so the card has room to breath on smaller viewports.
-
Instead of using
height: 100vh
on thebody
try usingmin-height: 100vh
so you don't run into overflow issues. -
Try using more descriptive CSS classes for your elements like
.card
,.card-title
and.card-description
. -
Try using relative CSS units like
rem
andem
. -
You don't have to wrap your image in a separate
<div>
, you can style the image directly if you want. -
Try using more semantic HTML element like
<p>
for your text.
I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord