Luiz Felippe• 80
@luizfbn
Posted
Nice solution! I found some things you can improve:
About HTML:
- You used a lot of divs, this is not wrong but you could use semantic HTML. For example, for list links you can use <ul> and <li> tags;
- There's no need to wrap a div inside a div like you did on class "container" and "main-menu". There's no difference between them.
About CSS:
- Links should be in a higher font weight;
- On link card hover, it should be background green and font color grey. You can check it on active state image, inside design folder;
- Try to keep it responsive (on small screens the card breaks);
- On style.css there are some empty classes;
- There are repeated style about attribution class in CSS file and HTML;
Good job and keep studying! :)
0
