Flex

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted almost 3 years ago

  Greeting @Usmaniyya ,

  I have few suggestions regarding your solution:

  • Remove /* height: 100%;*/ from the body. There's min-height: 100vh. using vh (viewport height) units allows the body to to grow taller if the content

  outgrows the visible page.

  • width: 320pxan explicit width is not a good way . consider using max-width to the card instead .

  .container {
      max-width: 320px;/* You should  use `em `and `rem ` units .Both `em `and 
  `rem` are flexible, Using`` px`` won't allow the user to control the font size based on 
  their needs.*/
      /* height: 100%; */
      /* margin-top: 5.4rem; */ remove the margin to center the card on the page. 
  }
  

  • It's recommended not to use px for font-size. you can use rem instead .

  Overall , your solution is good .Hopefully this feedback helps.

  Marked as helpful

  0