Flex / reponsive desing / bem

Community feedback

• 

  P

  j5•2,290

  @jmnyaregaPosted about 3 years ago

  Nice work on the challenge, I have a few recommendations:

  • You don't have to duplicate navigation HTML code for mobile and desktop. Use media queries to alter the styling depending on the screen size.

  • section should be under main not header.

  • Instead of leaving the alt attribute of the logo image undefined, you can pass the name of the company. In this case, Project Tracking will suffice.

  • Add either role="presentation" or alt="" aria-hidden="true" to a decorative image so that bots can skip it. without alt attribute, the screen readers will read out the path.

  • Add a hover state to the button and links.

  Otherwise, nicely done 👏👏

  Marked as helpful

  0
• 

  Liam R•425

  @Cooly-o-CatsPosted about 3 years ago

  ! | Este mensaje es traducido por google | ! ¡Gran trabajo! Parece increíble. ¿Quizás intentar arreglar un poco más tu logo? Se coloca en posiciones extrañas con demasiada frecuencia.

  Marked as helpful

  0