Skip to content
Submitted almost 3 years ago

Flex, pseudo before and after

Roshan K.C•150
@roshankcpkr
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • PhoenixDev22•16,950
    @PhoenixDev22Posted almost 3 years ago

    Hello @roshankcpkr,

    I have some suggestions regarding your solution:

    • First of all , I would suggest to have a separate file for the styles.

    • There should be two landmark components as children of the body element - a main (which will be the NFT card ) and a footer (which will be the attribution).<Footer> should be in the <main >read more about A simplified web page, might look something like this:

      • Anything with a hover style in a design means it's interactive. you need to add an interactive element<a> around the image Equilibrium #3429, Jules Wyvern .

    • For any decorative images, each img tag should have empty alt="" and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in( icon-view, icon-ethereum, icon-clock ).

    • the avatar 's alt shouldn't be profile pic it's meaningless , you can set to Jules Wyvern. Also , the main image alt needs to be changed

    • the link should be wrapping the original image and either have Sr-only text, an aria-label or alt text that says where that link takes you.

    • You can use an unordered list<ul> to wrap class="two-content"and in each <li>, there would be <img > and<p> (to wrap the text ). Then you can use flexbox properties to align them centrally.

    • Read more how to write an alt text

    • To center the card on the middle of the page , you can use the flexbox properties and min-height: 100vh for the <body>like this:

    body{
display:flex;
align-items: center;
justify-content: center;
width: 100%; /*If you set a page width, choose 100% over 100vw to avoid surprise horizontal scrollbars. */
min-height: 100vh;

    • I recommend to use em and rem units .Both em and rem are flexible, Using px won't allow the user to control the font size based on their needs.

    • Never use px for font size.

    • width: 375px;an explicit width is not a good way . Remove the width from the main component and change it to max width instead. That will let it shrink a little when it needs to.Remove width: 90%;

    You might have a look at my solution , to see how I did the hover effect on the image , it might my helps.

    Overall, your solution is good, Hopefully this feedback helps.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord