Design comparison
SolutionDesign
Community feedback
- @CaplexWPosted about 2 months ago
It's a good job! But I'd like to highlight a few things that might become an issue in the future:
- Try to avoid using
px
. It's an absolute unit, so it may cause problems in a responsive design. Instead, you can use responsive units likerem
orem
. You can read more about this in this article: Why you shouldn't use pixels for font-size. - Consider replacing or experimenting with
vh
andvw
when you use them inheight
andwidth
. It might sound good to display content depending on a screen's height and width; however, it might act unpredictably while the screen size changes. If you open your page in DevTools and play with the screen width, you'll see that the layout acts probably not like you expected it to. Giving a.container
propertyheight: 100%;
(100% from parent height) and using responsive unit likerem
to declare elements size, should solve the problem with changing screen size.
0 - Try to avoid using
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord