Flex

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Nathaniel, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility. You can replace it with the <div class="container"> as <main class="container">
  • to make it look as close to the design as possible set width: 25rem to article tag
  • Using <hr> for the line is not the best way because this tag have a semantic meaning... in this case use div with border-bottom because this line is decorative
  • use min-height: 100vh to container class instead of height, otherwise the content is cut off when the browser height is less than the content
  • add transition on the element with hover effect
  • instead of using px or % use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  1