Design comparison
Community feedback
- @sefaonderPosted 10 months ago
Hello @Sonyngui Thank you for sharing the project with us.
Yes, as you said, the preview is fine, but the screenshot seems to have some problems, but screnshoot is not always mandatory in desktop view. If you look at the project with responsive views, you will encounter this issue in mobile view.
Here are some tips for you to solve this error and improve your code:
-
Using
padding
instead ofmargin
will allow you to squeeze the child element inward (For more, please see CSS-PaddingVSMargin) -
The '%' values you give are based on the width or height of the parent element. You can use 'rem' or 'px' instead. (For more, please see CSS-Units)
-
I see 2 different class names in class naming, 'containerr' and 'container'. This is not really a serious problem, but in large and medium-sized projects, class names can sometimes be confusing and this can make it difficult to debug the code. There are different methods for CSS class naming. For example, you can use
containerr
->container
andcontainer
->card-container
.
Marked as helpful1@SonynguiPosted 10 months ago@sefaonder
Thanks for the help!
I'll note the tips and will do better in my next challenge.
0 -
- @SonynguiPosted 10 months ago
I don't know why the screenshot like that, the preview is pretty fine though
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord