Skip to content
Submitted about 2 years ago

Flex

Soulaima•10
@Soulaima1
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

All feedback are welcome thank you in advance

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello @Soulaima1 , Congratulations on completing this challenge!

    Your solution its almost done and I’ve some tips to help you to improve it:

    Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

    Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

    See the example below:

    <picture>
  <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
  <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
</picture>

    👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
    Soulaima•10
    @Soulaima1Posted about 2 years ago

    @correlucas ok thank you so much for taking the time and for help❤️

    0
  • Dicskson Owusu Nyantakyi•270
    @ondicksonPosted about 2 years ago

    Here are some few bugs you need to fix

    1. There's is a section element just under <body> in your html. You should delete that.

    2. You can delete article element too. it's not really needed in this kind of project.

    3. You put your <h1> element in <p> element. it should be something like

    <h1>Gabrielle Essence Eau De Parfum </h1>

    <p class="paragraph">A floral, solar and voluptuous interpretation composed by Olivier Polge, Perfumer-Creator for the House of CHANEL.</p>

    in your CSS

    1. You can remove this code.
    border: 0;
outline: 0;
text-decoration: none;
list-style: none;

    you should always try to put these sort of specific code on the elements you want them to be on.

    2.Before you begin each project, you must first read your style-guide. The style-guide in this challenge states that you use

    Family: [Montserrat](https://fonts.google.com/specimen/Montserrat)
- Weights: 500, 700

    - Family: [Fraunces](https://fonts.google.com/specimen/Fraunces)```
- Weights: 700

    How to add these font to your project? watch this tutorial

    There are so much more improvement to be made, you just need to continue learning.

    Marked as helpful
    0
    Soulaima•10
    @Soulaima1Posted about 2 years ago

    @ondickson ok thank you so much for taking the time and for help❤️

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord