@vanzasetia
Posted
Hello, Benjamin! š
Congratulations on finishing this challenge! š Your solution looks pretty good! š
Regarding your question, in this case, you don't need any "dynamic" value. However, it really depends on what you are trying to achieve. Usually, clamp() function is used for dynamic font size. For example:
body {
/* clamp(minimum, preferred, maximum) */
font-size: clamp(1rem, -0.875rem + 8.333vw, 3.5rem);
}
Now, two things that can be fixed.
- First, I recommend re-positioning the attribution because on mobile view, both landscape and portrait, the attribution is on the top of the card element. So, my recommendation is to not use absolute positioning to position the attribution.
- Second, there should not be text in
spananddivalone; instead wrap the text with a meaningful element. In this case, I recommend usingulandliinstead of thedivfor the bullets section.
That's it! Hope you find this useful! š
Marked as helpful
@Benjoow
Posted
@vanzasetia
Thank you for your advice ! I use clamp for my font size with a combinaison of rem for my font clamp et em for my padding. I don't know if it's good practice but it works :-)
About your points, I will change my span use and replace by ul and li even if it's not a semanticaly a list.
Thank you for taking your time to answer me !
@vanzasetia
Posted
@Benjoow You're welcome! If you want to know whether or not it should be a list or a heading, you can see the site without any styling and think of it as a document file. In my opinion, it's a list because without the styling it would look something like this.
- 10k+ companies
- 314 templates
- 12M+ queries
Marked as helpful
@Benjoow
Posted
@vanzasetia
It's very clear now ! I will remember to visualise the site without styling and are more focus on semantic, thank you Vanza ! :)
Oh and how can you implement your code window inside your message ?
@vanzasetia
Posted
@Benjoow Glad to know that! š
This textarea supports markdown syntax. You can see all the possible syntax by clicking the keyboard icon (it's above textarea, on the top right corner of the textarea).
