Skip to content
Submitted about 2 years ago

Flex, Grid, Responsive

Zoulanders•380
@AlexDDevv
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Four card feature section
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

My solution for this challenge !

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello Zoulanders, congratulations on your first solution!👋 Welcome to the Frontend Mentor Coding Community!

    Nice code and nice solution! You did a good job here putting everything together. I’ve some suggestions for you:

    1.Add the website favicon inserting the svg image inside the <head>. <link rel="icon" type="image/x-icon" href="./images/favicon-32x32.png">

    2.Improve the semantic replacing the <div> used for the four cards and use instead <article> that is a better tag, remember that <div> doesn’t have any effective meaning is just a block elements, so for big block of elements use semantic tags.This a good resource to understand more about semantic tags: https://www.w3schools.com/html/html5_semantic_elements.asp

    3.I saw that for some properties you’ve used rem and for others px. In this case, it is better to use only one kind of unit to have a better organization for your code. relative units as rem or em have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord