Skip to content
Submitted over 3 years ago

Flex, Grid, Mobile first approach.

Shubham Hirakki•60
@shub78910
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Fylo dark theme landing page
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

Please let me know if I need to improve anything in my code. I know, I haven't made an exact copy of the design, but I want someone to validate the quality of code, so please, have a look and suggest the best pracs. Thanks in advance!

Community feedback

  • Mojtaba Mosavi•3,760
    @MojtabaMosaviPosted over 3 years ago

    @shub78910 good job, it seems you have rushed this one a bit. Beside fixing issues in the raport above consider refactoring the following things.

    1. Wrap the text the inside <li> elements in your nav inside <a> tag since it should be clickable link, not only plain text. The icons and links in your footer should also be wrapped inside a <a> tag.

    2. If there is a suitable html tag for a certain task it should be used, for example in you footer you wrap your list items in div but the there's a specific tag for this task <ul> and instead of <div class="mainContent"> you can use a <main> tag.

    Happy coding :)

    0
    Shubham Hirakki•60
    @shub78910Posted over 3 years ago

    @MojtabaMosavi Got it, sure thing. I'll make sure to implement these things. Thank you for the review!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord