Flex for signup form, floated error icon, flex and vw on desktop body

Community feedback

• 

  Alex•1,090

  @AlexBueckigPosted about 5 years ago

  Hi @J-Guidry,

  in my solution I actually included the parapgraph in the form tag just to get rid of another additional wrapper-div. In my opinion its totally fine to add the paragraph inside to form tag because its a description/legal-notice which is contextually tied to submitting the form/pressing the button.

  Maybe someone else can confirm or deny? 😃

  1
• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  Hey Jhabari, either way would be fine! You've done a good job on this challenge. One thing I'd recommend is to add the desktop background in for larger screens. At the moment it doesn't change from the mobile background-image.

  How did you get on with it? Did you learn anything new while building it?

  0

  ---

  

  Jhabari Guidry•190

  @J-GuidryPosted about 5 years ago

  Wow. The desktop background image completely slipped my mind. How could I forget that? As for learning, I did learn how to make better use of widths and max widths to control centering and space around elements.

  0