Skip to content
Submitted about 2 years ago

flex, flex, flex, percentage !!

nelson•160
@Hyogan
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Huddle landing page with a single introductory section
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

i had some dificulties at the level of the fav icons, as you'll see , i put two hover , one on the 'i' tag and one the "li" tag ! i don't know why the hover on the li don't change the color of icons

Community feedback

  • Adriano•38,080
    @AdrianoEscarabotePosted about 2 years ago

    Hi nelson, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    The rest is great!!

    Hope it helps...👍

    Marked as helpful
    0
    nelson•160
    @HyoganPosted about 2 years ago

    @AdrianoEscarabote thank you so much for your comment ! I will try to put that in practice

    0
  • Hyron•5,870
    @hyrongennikePosted about 2 years ago

    Hi @Hyogan,

    Congrats on completing the challenge

    You would add the hover on the a tag.

    On the body rule add margin: 0 auto to center the content and a max-width: 1440px remove the width.

    for mobile you can add the following.

    @media (max-width: 768px) {
main {
    flex-direction: column;
    margin: 0 auto;
    max-width: 375px;
    justify-content: center;
    align-items: center;
}
main .page-right-description, main .page-right-description *, main img {
    width: 100%;
    max-width: 100%;
    text-align: center;
}

footer {
    display: flex;
    margin: 1rem;
    justify-content: center;
}
}

    Also check the report above there are a few issues.

    Hope this is helpful. Let me know if you have any other questions.

    Marked as helpful
    0
    nelson•160
    @HyoganPosted about 2 years ago

    @hyrongennike thank you so much for your comment ! I will try to put that in pratice ! I have a question, Please , where is the defference betwen this --->main .page-right-description, main .page-right-description *, main img and this --> .page-right-description , ..page-right-description * , main img

    in the second case, i didn't precised the parents of the elements, i would like to kwow if it really matter !!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord