flex box

Community feedback

• 

  Ahmed Faisal•5,095

  @afrusselPosted about 3 years ago

  Good work, the background image is missing. I would like to request you please take a look at my solution it may help you to find your issues

  2
• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, great work on this one. The layout in desktop seems different but is fine for now also the background-image only shows when the layout is being resized to its mobile layout.

  Some suggestions would be:

  • On your body tag, using height: 100vh is not really good. Using this limits the element's height based on the remaining viewport's height. Replacing it with min-height: 100vh is much better, since this takes the whole height as well and it will expand if it needs to, unlike height: 100vh which doesn't expand because it is already fixed.
  • The text after the h1 element should not be using ulelement.ulelement for contents that is a list and that is not a list. Usingptag alone to contain those text is much greater than usingul`.
  • The text for the annual plan as well, you should not use ul element on those. The annual plan could be a heading tag and the text below it could be a span or p tag.
  • Lastly, adding some padding to the top and bottom of the body tag would be really great , so that it prevents the content from touching the ceiling and flooring.

  Aside from those, great job.

  0