flex box ,, transform ,, position

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Ali, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • you can use article tag instead of a simple div to the container card for improve the Accessibility
  • centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  0

  ---

  

  yishak abrham•2,150

  @yishak621Posted about 2 years ago

  @denielden hi bro how can i deploy my site free git and netlify is not working for me

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @yishak621 now I come to see in your profile if I can help you :)

  0

  

  Ali Mohamed•300

  @Ali503-7Posted about 2 years ago

  @denielden thanks, daniel for your valuable advice hope to see your comments on my following challenges

  1

  

  Ali Mohamed•300

  @Ali503-7Posted about 2 years ago

  @yishak621 hi man well I'm using GitHub to host my Challenges https://youtu.be/DqjPr7auwdY This video may be useful

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @Ali503-7 Sure! You are welcome and keep it up :)

  0

  

  yishak abrham•2,150

  @yishak621Posted about 2 years ago

  @Ali503-7 sure thanks

  0