Skip to content
Submitted 3 months ago

Flex box

Ahmed•10
@ahmeddin12
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • EfthymiosK•180
    @EfthymiosKPosted 2 months ago

    Hi my friend! - First of all, I think that you should totally remove the attribution div. As you can see on your own there is no such thing on the original design. - If you look at the figma file you will see that the actual dimensions of the component are 320px x 499px. Yours is smaller (inspect with chrome dev tools to see for yourself). - You are using an H2 tag insteed of an H1. There should always be an H1 in a website (I learned that from tests frontendMentor did to my code). - You don't use semantic HTML. Perphaps after <body> you should include all your code in a <main> . Other than the above, I think it was a good try!

    0
    Ahmed•10
    @ahmeddin12Posted 2 months ago

    @EfthymiosK Thank you for your supportive comment. Actually this was my first work. I will do my best to improve it.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord