Design comparison
Solution retrospective
Any suggestion is welcome.
Community feedback
- @pikapikamartPosted about 3 years ago
Hey, great work on this one. The layout in desktop is good as well as for mobile layout. Though when the point of transition between mobile and desktop, the elements are being hidden, thus creating a horizontal scroll, you might want to test first and check that one out.
Just to add some suggestions aside from hardy already mentioned:
- Wrapping the whole layout inside a
main
element. This makes your structure more semantic asmain
element helps other user to properly navigate your website. - Thes text:
Powered by Technology
could be wrapped inside a
h1
tag, this will clear up an issue with the report, as well as adding more meaning to the website.- Lastly, maybe try adding some custom layout. Since you are using
grid
. You could make a 2x2 layout something like that, instead of just having the desktop layout, then followed by on the mobile layout which is just one straight layout.
Aside from those, great work.
Marked as helpful0 - Wrapping the whole layout inside a
- @hardy333Posted about 3 years ago
Hey, nice job everything looks good, but try to lower the height of white space from top of the window and heading it is too big.
Also I suggest to use semantic html tags such as <section></section> and <article> tags for example.
Good luck and have a nice day.
3
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord