Design comparison
Solution retrospective
I attempted Frontend Mentor's Challenge on the four card feature section. I'd be glad to receive feedback on my code. Thank you
Community feedback
- @jiroRiPosted over 4 years ago
Hi! A very neat solution you have there ✨ Especially on screens below 1440px.
I have a few tips, albeit minor, but would really help with the overall aesthetic and accuracy(?).
-
I suggest for you to set a max width inside your
.container
. This can be a quick and temporary solution(until you figure out a better one) so you won't have any trouble with the elements'flex-wrap
behaviour in larger screens(more than 1440px) e.g:max-width: 1366px;
-
As for the colors.. It is best for you to look thoroughly into the
styles-guide.md
file(included within the Starter Pack) and identify which elements need to use which before doing everything else.
Overall, you really did a good job particularly on the ✨responsiveness ✨!! No issues too!
Keep at it bro! 💪
Edit: (I apologize if I don't know why I am being downvoted. I humbly ask someone to correct me or let me be aware of what I did wrong, so I can learn a very valueble lesson.)
1@Jonie23Posted over 4 years ago@jiroRi Thank you very much. I will apply the temporary solution you provided till I get a much better one. Really appreciate the feedback
1@mattstuddertPosted over 4 years ago@jiroRi not sure why either, Jiro. You’ve got an upvote from me. Great feedback! 👍
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord