Design comparison
Solution retrospective
hey guys , this is my solutions to the challenge , i didn't submit for a wail now so i find it very hard to get my skills back , this challenge took me alot of time and i did find it hard , so exuse my logic that i came up with , and also my code that look a bit messy if anyone can give me some tips to get back on track that will be very helpful , and also i did not know hwo to change the background when the menu expended . I realy need a feedback if that's ok . thanks guys making this place a very good community
Community feedback
- @hebrerilloPosted over 2 years ago
Hello Abdellah! You did a good work! I will give you some tips.
The items of the header are not centered vertically nor horizontally. Just add some flexbox declarations to the header to fix it:
header { display: flex; flex-direction: row; padding: 1.5rem 2.5rem; align-items: center; justify-content: space-between; }
I also added some horizontal padding to make it look nicer.
You also have a JavaScript event handler that reloads the page whenever the browser is resized. Maybe you forgot to remove that code.
Marked as helpful1@abdellahelaajjouriPosted over 2 years ago@hebrerillo thanks men , the javascript event for realoading the first code after it's changed in by the mobilMarkUp in js , if i delete this ligne of code the mobilMarkUp for the header it will stay even if i resize to the desktop designe , I realy apperciate your time helping me .
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord