Skip to content
Submitted almost 3 years ago

Flex box

rabiharb•530
@rabiharb
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...FAQ accordion card
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I don't think I've done a great job with this one would appreciate any feedback! Thanks.

Community feedback

  • bunee•2,020
    @buneeIsSloPosted almost 3 years ago

    Hey! @rabiharbj, Good job on the challenge. Your webpage responds very well. Here's a few suggestions from my side:

    1. In JavaScript you should use === and !== to check for strict equality and strict inequality respectively. So on line 26 in your script file, change the != to !==

    2. I you weren't aware, You solve this challenge without any JavaScript using the <details> tag.

    Hope this helps :)

    Marked as helpful
    1
  • rabiharb•530
    @rabiharbPosted almost 3 years ago

    Much appreciation @bunee. Thanks for the JS fix, helps indeed. I was aware of the details tag I just didn't know I can customize it with CSS, but after your eye-opener, I did some digging and found a way.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord