flex box

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  Nice work on this challenge and congrats on submitting your first solution! I was going to mention the lack of alt attributes that was picked up in the report, but I see you've already added them. You can generate a new report if you like from the report page. This will update it and remove those errors now that they've been resolved.

  Keep up the great work!

  0

  ---

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  @B-shadow you're welcome! Happy to help!

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  @B-shadow no worries! I've got a few small pointers, but overall everything looks good! Here are some things I'd recommend taking a look at:

  • You're using float, which I'd strongly recommend avoiding these days. Instead, I'd look to Flexbox or Grid to layout elements. They're much better tools for the job.
  • You're duplicating a lot of styles between the numbered cards. One way to reduce the CSS would be to have a generic .card class that holds all common styles, then have extra classes that provide the extra styles.
  • In your HTML it's always a good idea to use semantic structural elements like header, section, footer, etc. However this is just a single component challenge, so it's not critical here.

  Hope that helps! 👍

  0

  

  B-Shadoink•80

  @B-ShadoinkPosted about 5 years ago

  @mattstuddert thanks a lot matt this really helps, i'll try to do a better work next time :)

  0

  

  B-Shadoink•80

  @B-ShadoinkPosted about 5 years ago

  @mattstuddert thanks, did you check the entire code to make sure it's all good? i always think i did something wrong somewhere lol.

  0