Travolgi 🍕• 31,420
@denielden
Posted
Hi Ehab, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add
maintag and wrap the card for Accessibility - remove all
marginfromcardclass because with flex they are superfluous - add
min-heigth: 100vhto.containerclass because Flexbox aligns to the size of the parent container - add
align-items: center;to.containerclass for center the card vertically. Read here -> best flex guide - instead of using
pxtry to use relative units of measurement -> read here
Overall you did well :)
Hope this help and happy coding!
Marked as helpful
0
Ehab Nada• 120
@hopamnada
Posted
@denielden Thank you so much Deniel, This comment helped me a lot.
1
