Flex box

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Ehab, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • remove all margin from card class because with flex they are superfluous
  • add min-heigth: 100vh to .container class because Flexbox aligns to the size of the parent container
  • add align-items: center; to .container class for center the card vertically. Read here -> best flex guide
  • instead of using px try to use relative units of measurement -> read here

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  0

  ---

  

  Ehab Nada•120

  @hopamnadaPosted almost 3 years ago

  @denielden Thank you so much Deniel, This comment helped me a lot.

  1
• 

  optimusprime202•1,200

  @optimusprime202Posted almost 3 years ago

  Hey @hopamnada, Congratulations, you got it right!

  0
• 

  Hexer•3,660

  @EmmanuelHexerPosted almost 3 years ago

  Great work overall man. Keep it up

  0

  ---

  

  Ehab Nada•120

  @hopamnadaPosted almost 3 years ago

  @Phalcin Thank you bro

  0