Skip to content
Submitted over 1 year ago

Flex box

Happiness•50
@Homorkhay
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I used like up to two days to learn Flexbox. It gave me quite a tough time learning Flexbox How can I get better at CSS grid and Flexbox? Really want to be better at that for the moment. I'm still a newbie tho.

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    QR iMAGE ALT TEXT 📸:

    • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.
    • The alt with qr_code is not even explaining for what the QR image need to be used.
    • So update the alt with meaningful text which explains like QR code to frontendmentor.io
    • Example: <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    0
    Happiness•50
    @HomorkhayPosted over 1 year ago

    @0xAbdulKhalid Thank you sir! I will make the necessary changes

    0
  • Account deleted

    Hello Coder 😊

    Your solution is great✨ and congratulations for successfully completing an another newbie challenge🎉

    and there is a small suggestion that might be helpful for you

    min-height :

    You can use min-height instead of height

    because height will put your element to a size of 100% of it's container. min-height will put the element to min 100% of the container size.

    if we set min-height: 100vh then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space

    and it will helpful when you make responsive solutions

    QR code image : The alt attribute provides alternative information for an image if a user for some reason cannot view it and screen readers use the alt attribute to convey the message about the image

    And here the qr code image is not for decoration and that's why you need to write a alt attribute value for it

    <img src="images/image-qr-code.png" alt="qr code">

    Hope that was helpful 😊

    Marked as helpful
    0
    Happiness•50
    @HomorkhayPosted over 1 year ago

    @MrSandipSharma Thank you sir! I'm good now.. made the necessary changes ..I really appreciate this sir🙏

    0
    Account deleted

    @Homorkhay

    I am glad that was helpful for you 😊

    0
  • _nehal💎•6,710
    @NehalSahu8055Posted over 1 year ago

    Hello Coder 👋.

    Congratulations on successfully completing the challenge! 🎉

    Few suggestions regarding design.

    ➨ Your livesite url is incorrect. replace it with this url link

    ➨ Use min-height instead of height in body.

    ➨ Use Semantics for proper design of your code.

    <body>
<header>
<nav>...</nav>
</header>
<main>...</main>
<footer>...</footer>
</body>

    or alternatively

    <body>
<div class="container" role="main">
/html code goes here: 📃
</div>
</body>

    I hope you find this helpful.

    Happy coding😄

    Marked as helpful
    0
    Happiness•50
    @HomorkhayPosted over 1 year ago

    Hi @NehalSahu8055 Thanks for the comment. I really appreciate but the project isn't about header and stuffs .. To use proper semantics you've mentioned above , I think the second one is better thank you.

    1
    _nehal💎•6,710
    @NehalSahu8055Posted over 1 year ago

    @Homorkhay
    That's just a template you have to use the necessary stuff.

    Always ready to help 🙂

    Marked as helpful
    0
    Happiness•50
    @HomorkhayPosted over 1 year ago

    @NehalSahu8055 Ohh yes! Thank you sir!

    0
    Happiness•50
    @HomorkhayPosted over 1 year ago

    @NehalSahu8055 Made the necessary changes. I'm good now .. Thanks for the assistance sir🙏

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord