Flex, border radius, shadows

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @DamianC86 👋, good job on completing this challenge! 🎉

  I have some suggestions you might consider to improve your code:

  • Use the <main> tag to wrap all the main content in your solution rather than <div class="card">.
  • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
  • Use min-height: 100vh to body selector, with this property you set a height and let the element grow even more if necessary. Your elements will also be vertically centered when you use this property.
  • You should not name your class with the camelCase convention. Use naming naming conventions to name it.

  I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  Marked as helpful

  1

  ---

  

  Ezvra•10

  @DamianC86Posted about 2 years ago

  @MelvinAguilar Hello! Thank you very much for taking your time to see my first work and help me improve! I'll keep that in mind!

  1
• 

  Hamid Mahmood•540

  @Hamid210545Posted about 2 years ago

  Hello .... You have done an amazing job .... but let me correct you..... your card is not in center of the desktop screens but you can fix it b taking a simple step...... Give body tag these properties in css..... { display: flex; justify-content: center; align-items: center; } .... I hope this will correct your problem..............................Thanks!

  Marked as helpful

  0

  ---

  

  Ezvra•10

  @DamianC86Posted about 2 years ago

  @Hamid210545 Hello! Thank you very much for taking your time to see my first work and help me improve! I'll keep that in mind!

  0
• 

  Randy Ochoa•40

  @SoyRandy708Posted about 2 years ago

  Agregale al heigt del un 100vh para que tome el 100% de la pantalla en la que este y la tarjeta quede en el centro de la pantalla verticalmente

  Marked as helpful

  0

  ---

  

  Ezvra•10

  @DamianC86Posted about 2 years ago

  @SoyRandy708 Gracias Randy! Lo agregué como me comentaste tu y Melvin. :D Ahora a seguir

  1