Skip to content
Submitted over 2 years ago

Flex and Sass

Renato Lacerda•160
@ralacerda
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Probably really bad practices.
By far the worse thing was setting the right letter-spacing.

I'm not even sure if I should be using flex for this, it might be overkill. I'm not sure how to include the footer without changing the position of the main component.

Community feedback

  • Jacek•50
    @JacekhackingPosted over 2 years ago

    Hey Renato! I think you did well. Honestly dont know a whole lot about scss best practices as I do most of my styling in either styled components or straight css. But I dont think it's overkill to use flex if that's what's easiest for you. One thing i did notice and it's pretty small but you've wrapped your content div inside of a section and that section isn't actually doing anything for you. Other than that it looks good! Congrats on finishing :)

    Marked as helpful
    0
  • Renato Lacerda•160
    @ralacerdaPosted over 2 years ago

    I just noticed I missed the box shadows. It's a small detail, but I think it makes the design "pop" more. It's not something I would pay attention to before, but I'll from now on.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord