Design comparison
Solution retrospective
Can i some feedback please? I tried with the mobile first approach for the styling Thanks :)
Community feedback
- @mattstuddertPosted over 4 years ago
Nice work on this challenge, Ornella! How did you get on working mobile-first? Did you have any difficulties?
Your code looks great. The one thing I'd recommend avoiding is setting the
height
on lots of elements. Wherever possible, I let the height of the inner content dictate the height of the parent element, instead of setting an explicit height on the parent itself. This means the parent can resize based on the height of the content within, which is especially important when building responsive websites.There are times when you can set the height of elements, but these are usually very specific circumstances, like when you're setting the height of a decorative element or icon.
I hope that all makes sense. Let me know if you have any questions! 🙂
0@ornel77Posted over 4 years ago@mattstuddert Hello yeah for the mobile first I don't know if I used the right technique but I guess it's not too bad :) Thank you for the height advice. And if you have any tips on how to approach mobile first technique i would be glad to hear it :)
0@mattstuddertPosted over 4 years ago@ornel77 the main thing I'd recommend is to just keep practicing! You'll start refining your workflow and get faster with it. Keep up the great work!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord