Skip to content
Submitted over 1 year ago

flex

Layomi1•20
@Layomi1
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

  • the text alignment

Community feedback

  • Hassia Issah•50,650
    @HassiaiPosted over 1 year ago

    Replace <section class="card"> with the main tag and <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

    To center .card on the page using flexbox, replace the height in the body with min-height: 100vh.

    For a responsive content, replace the width in .card with max-width, there is no need for the height in .card and increase its padding value. padding:16px

    Give the img a max-width of 100% for a responsive image and a border-radius value, the rest are not needed.

    Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

    Hope am helpful.

    Well done for completing this challenge. HAPPY CODING

    Marked as helpful
    0
  • Gabriel Gusso•250
    @g-pgPosted over 1 year ago

    Hey Layomi.

    To correct the text alignment you could try to increase the font-size. Also, it's a good practice to use "em" or "rem" units on font sizes instead of pixels. They are proportional to the user's browser settings, making them more responsible.

    Another tip is to avoid using an <h3> tag if you didn't use an <h2> and so on. Ensure your heading tags follow an order.

    Finally, you could wrap all your content inside the <body> tag in a <main> tag, since the card is your main content in this page.

    Marked as helpful
    0
  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    HTML 🏷️:

    • This solution generates accessibility error reports due to incorrect usage of semantic markup, which confuses the landmark of this webpage
    • So fix it by replacing the <section class="card"> with semantic element <main> in your index.html file to improve accessibility and organization of your page.
    • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>
    • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

    HEADINGS ⚠️:

    • And, this solution had generated accessibility error report due to lack of level-one heading <h1>
    • Every site must want at least one h1 element identifying and describing the main content of the page.
    • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
    • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord