Design comparison
SolutionDesign
Community feedback
- @kaamiikPosted about 1 month ago
Hi. I have some notes I wanna mention:
-
Your links take you to a new page. So you better use
a
tag instead of button. Also the links are like a list of items. So you can useul
withli
for them. -
Use a strong CSS reset for your CSS. Andy Bell's is good.
-
For the font-size, You have to use
rem
for unit instead ofpx
. Here explains why . Also for padding and margins you can useem
orrem
.
Marked as helpful0 -
- @rishavdhungelPosted about 1 month ago
Looks great, it would be better to have a <main></main> container in the body and put everything within it.
<body> <header> <!-- Header content --> </header> <main> <!-- Main content goes here --> </main> <footer> <!-- Footer content --> </footer> </body>
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord